some fixes for messages without size header. - #1758
Merged
Merged
Conversation
Normally, a notification message should include the size of the file to be transferred. Following Postel's maxim, we want to handle it being missing elegantly: * when the field is missing, don't crash #1754 * When we finish downloading a file, we know it's actual size, and if the field is missing it should be added.
Test Results360 tests 359 ✅ 1m 49s ⏱️ Results for commit def8242. ♻️ This comment has been updated with latest results. |
Member
|
The logic looks good to me. I think it also makes sense to set the message size if the source does not provide one. |
reidsunderland
approved these changes
Aug 7, 2026
reidsunderland
left a comment
reidsunderland
left a comment
Member
There was a problem hiding this comment.
I agree, it looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1754
Normally, a notification message should include the size of the file to be transferred. Following Postel's maxim, we want to handle it being missing elegantly:
fileSizeMaxand when a message is received without the size set #1754