feat: Wire AndroidTypeResolverProvider and ServiceLoader Tests#88
Conversation
- Added androidx.compose.ui:ui:1.11.3 to version catalog. - Renamed AndroidResolverProvider to AndroidTypeResolverProvider and updated class name. - Manually registered AndroidTypeResolverProvider in META-INF/services to avoid compilation issues with autoservice-ir in the Android module. - Added integration tests in AndroidServiceLoaderTest to verify ServiceLoader discovery and chain integrity. - Updated android/build.gradle.kts with necessary test dependencies. Co-authored-by: MessiasLima <10220064+MessiasLima@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
- Added androidx.compose.ui:ui:1.11.3 to version catalog. - Renamed AndroidResolverProvider to AndroidTypeResolverProvider and updated class name. - Manually registered AndroidTypeResolverProvider in META-INF/services to avoid compilation issues with autoservice-ir in the Android module. - Added integration tests in AndroidServiceLoaderTest to verify ServiceLoader discovery and chain integrity. - Updated android/build.gradle.kts with necessary test dependencies. Co-authored-by: MessiasLima <10220064+MessiasLima@users.noreply.github.com>
This change wires the
AndroidTypeResolverProviderto thesomelibrary'sServiceLoaderdiscovery mechanism.What went wrong:
I encountered a persistent compilation error when applying the
autoservice-irplugin to the:androidmodule:Cannot query the value of property 'classesDirectory' because it has no value available.This appears to be a compatibility issue between the plugin and the Android Gradle Plugin version or configuration.How I fixed it:
To ensure the provider is still discovered as required by the design, I implemented manual registration by creating the
META-INF/services/dev.appoutlet.some.core.TypeResolverProviderfile in the:androidmodule's resources. This achieves the same end result as@AutoServicewithout the compiler plugin dependency in this specific module.Changes:
androidx.compose.ui:uitogradle/libs.versions.tomland:androidmodule.AndroidResolverProvidertoAndroidTypeResolverProvideras requested.android/src/main/resources/META-INF/services/.AndroidServiceLoaderTestin the:androidmodule to verify thatsomeSetup {}correctly discovers the Android provider viaServiceLoaderand that the resolver chain remains functional (e.g., resolvingString).:androidbuild configuration to support JVM unit tests with Compose on the classpath.Fixes #83
PR created automatically by Jules for task 12906260935489321471 started by @MessiasLima