Skip to content

feat: Wire AndroidTypeResolverProvider and ServiceLoader Tests#88

Merged
MessiasLima merged 6 commits into
mainfrom
android-resolver-provider-wiring-12906260935489321471
Jun 22, 2026
Merged

feat: Wire AndroidTypeResolverProvider and ServiceLoader Tests#88
MessiasLima merged 6 commits into
mainfrom
android-resolver-provider-wiring-12906260935489321471

Conversation

@MessiasLima

Copy link
Copy Markdown
Owner

This change wires the AndroidTypeResolverProvider to the some library's ServiceLoader discovery mechanism.

What went wrong:
I encountered a persistent compilation error when applying the autoservice-ir plugin to the :android module: Cannot query the value of property 'classesDirectory' because it has no value available. This appears to be a compatibility issue between the plugin and the Android Gradle Plugin version or configuration.

How I fixed it:
To ensure the provider is still discovered as required by the design, I implemented manual registration by creating the META-INF/services/dev.appoutlet.some.core.TypeResolverProvider file in the :android module's resources. This achieves the same end result as @AutoService without the compiler plugin dependency in this specific module.

Changes:

  1. Dependency Management: Added androidx.compose.ui:ui to gradle/libs.versions.toml and :android module.
  2. Provider Rename: Renamed AndroidResolverProvider to AndroidTypeResolverProvider as requested.
  3. Service Discovery: Manually registered the provider in android/src/main/resources/META-INF/services/.
  4. Integration Testing: Added AndroidServiceLoaderTest in the :android module to verify that someSetup {} correctly discovers the Android provider via ServiceLoader and that the resolver chain remains functional (e.g., resolving String).
  5. Test Infrastructure: Updated :android build configuration to support JVM unit tests with Compose on the classpath.

Fixes #83


PR created automatically by Jules for task 12906260935489321471 started by @MessiasLima

- Added androidx.compose.ui:ui:1.11.3 to version catalog.
- Renamed AndroidResolverProvider to AndroidTypeResolverProvider and updated class name.
- Manually registered AndroidTypeResolverProvider in META-INF/services to avoid compilation issues with autoservice-ir in the Android module.
- Added integration tests in AndroidServiceLoaderTest to verify ServiceLoader discovery and chain integrity.
- Updated android/build.gradle.kts with necessary test dependencies.

Co-authored-by: MessiasLima <10220064+MessiasLima@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

- Added androidx.compose.ui:ui:1.11.3 to version catalog.
- Renamed AndroidResolverProvider to AndroidTypeResolverProvider and updated class name.
- Manually registered AndroidTypeResolverProvider in META-INF/services to avoid compilation issues with autoservice-ir in the Android module.
- Added integration tests in AndroidServiceLoaderTest to verify ServiceLoader discovery and chain integrity.
- Updated android/build.gradle.kts with necessary test dependencies.

Co-authored-by: MessiasLima <10220064+MessiasLima@users.noreply.github.com>
Comment thread android/src/test/java/dev/appoutlet/some/android/AndroidServiceLoaderTest.kt Outdated
@MessiasLima MessiasLima changed the title Wire AndroidTypeResolverProvider and ServiceLoader Tests feat: Wire AndroidTypeResolverProvider and ServiceLoader Tests Jun 22, 2026
@MessiasLima MessiasLima merged commit e328bcb into main Jun 22, 2026
1 check passed
@MessiasLima MessiasLima deleted the android-resolver-provider-wiring-12906260935489321471 branch June 22, 2026 13:01
@github-project-automation github-project-automation Bot moved this from Ready to Done in Some Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Wire AndroidTypeResolverProvider and add ServiceLoader integration tests

1 participant