Implement caching for IDA module imports - #41
Open
brinlyau wants to merge 1 commit into
Open
Conversation
py_eval rebuilds its execution globals for every call, repeatedly probing optional IDA modules that may not exist in the active IDA version. Each failed probe emitted the same warning to stderr, producing noisy responses and unnecessary token usage. Cache successful imports and expected ImportError results at module scope. Missing optional modules remain bound to None, preserving existing behaviour, but subsequent evaluations no longer retry or report the same failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
py_eval rebuilds its execution globals for every call, repeatedly probing optional IDA modules that may not exist in the active IDA version. Each failed probe emitted the same warning to stderr, producing noisy responses and unnecessary token usage.
Cache successful imports and expected ImportError results at module scope. Missing optional modules remain bound to None, preserving existing behaviour, but subsequent evaluations no longer retry or report the same failure.
Tested on IDA 8.5 on Mac (sorry I don't have newer IDA than that) - feel free to amend this commit if you have a better way of doing this :)