docs(similarity): correct the fallback key comment - #36
Merged
Conversation
The comment said "path + size" but the seed is binary_path + function_count. Noted while reviewing #24, which describes the same code correctly. Also record the collision case the fallback accepts, so the weakness is visible at the site rather than only in the issue. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only fix spotted while reviewing #24.
_instance_key's fallback comment said "path + size", but the seed isbinary_path+function_count. #24 describes the code correctly; the commentwas the stale one.
Also records the collision the fallback accepts (two different binaries at the
same path with equal function counts), so the weakness is visible where the code
lives rather than only in the issue. The underlying design question stays in #24.
No behaviour change.
🤖 Generated with Claude Code