Remove identity initContainer from default values (1.0.1)#1
Open
bjarneo wants to merge 1 commit into
Open
Conversation
The default values.yaml shipped an identity-specific db-migration initContainer (image: identity, command: npm run migration:run, secret: identity), so any app using this chart without overriding initContainers inherited an identity init container. Default it to [] so the chart stays generic; apps that need an init container declare their own. Also add a .helmignore: the package was sweeping .git/, index.yaml, robots.txt and the published .tgz into the chart archive, so the new 1.0.1 package only contains the chart files. Bumped to 1.0.1; 1.0.0 is left in the index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
initContainersto[]invalues.yaml. It previously shipped an identity-specificdb-migrationinitContainer (image: identity,command: npm run migration:run,secret: identity), so every consumer that didn't overrideinitContainersgot an identity init container injected into its Deployment (this is how it leaked into mentos-api).1.0.1and publish a clean package..helmignore. The previous packages bundled.git/,index.yaml,robots.txtand the published.tgzinto the chart archive; with the ignore file the1.0.1package contains only the chart files.Why
The default values had the
identityservice's migration init container baked in, making the chart non-generic.identitydeclares its own init container in its values, so nothing depends on this default.Notes
1.0.0is left untouched in the index for existing consumers.1.0.1; consumers can move to it to drop anyinitContainers: []override.