Replace PostHog with self-hosted Umami analytics - #131
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50471ae69b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| defer | ||
| src={UMAMI_SCRIPT_URL} | ||
| data-website-id={UMAMI_WEBSITE_ID} | ||
| data-domains="saveit.now" |
There was a problem hiding this comment.
Strip sensitive query strings from Umami pageviews
With the global Umami script enabled here, automatic pageviews will include the page URL's search string unless it is explicitly excluded; this app has real secrets/PII in query params, e.g. /auth/mobile-login?token=..., /unsubscribe/$userId?token=..., and /signin?email=.... When those links are opened on saveit.now, the tokens/emails get sent to analytics, so add data-exclude-search="true" or a data-before-send scrubber before enabling the tracker globally.
Useful? React with 👍 / 👎.
What changed
https://analytics.melvynx.dev/script.jssaveit.nowhostname and respect Do Not TrackSaveIt events
Validation
pnpm --filter web typecheckpnpm lint(0 errors; existing repository warnings only)pnpm --filter web test:ci(183 tests passed)pnpm vercel-buildhttps://analytics.melvynx.devand/api/heartbeatreturn HTTP 200 with valid Let's Encrypt TLS