Skip to content

Fix build on suse16 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bureddy merged 1 commit into from
Mar 19, 2026
Merged

Fix build on suse16 #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ucx_plugin.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ ncclResult_t nccl_ucx_accept(void *listen_comm, void **recv_comm, ncclNetDeviceH
UCXCHECK(ucp_ep_create(r_comm->ucx_worker->worker, &ep_params, &r_comm->ep));
NCCLCHECK(ncclSocketRecv(&r_comm->sock, &r_comm->ctag, sizeof(ucp_tag_t)));

r_comm->gpuFlush.enabled = (nccl_p2p_gdr_support(l_comm->dev) == ncclSuccess);
r_comm->gpuFlush.enabled = (nccl_p2p_gdr_support() == ncclSuccess);
if (r_comm->gpuFlush.enabled) {
ucp_address_t *my_addr;
size_t local_addr_len;
Expand Down
4 changes: 2 additions & 2 deletions src/ucx_rma_plugin.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,7 @@ ncclResult_t nccl_ucx_rma_accept(void *listen_comm, void **recv_comm, ncclNetDev
UCXCHECK(ucp_ep_rkey_unpack(r_comm->ep, rkey_buf, &r_comm->rem_fifo.rkey));
free(rkey_buf);

if (nccl_p2p_gdr_support(l_comm->dev) == ncclSuccess) {
if (nccl_p2p_gdr_support() == ncclSuccess) {
r_comm->super.gpuFlush.enabled = 1;
}

Expand Down Expand Up @@ -1446,4 +1446,4 @@ ncclNet_v6_t ucxRmaPlugin_v6 = {
.closeSend = nccl_ucx_rma_close_send,
.closeRecv = nccl_ucx_rma_close_recv,
.closeListen = nccl_ucx_rma_close_listen
};
};
2 changes: 1 addition & 1 deletion src/ucx_uct_lib.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ ncclResult_t nccl_uct_close_listen(void *listen_comm) {
static ncclResult_t nccl_uct_comm_gpu_flush_init(nccl_uct_comm_t *comm) {
size_t size = comm->uct_iface->min_get_zcopy;

comm->gpu_flush.enabled = (nccl_p2p_gdr_support(comm->dev) == ncclSuccess) ||
comm->gpu_flush.enabled = (nccl_p2p_gdr_support() == ncclSuccess) ||
(nccl_p2p_dmabuf_support(comm->dev) == ncclSuccess);

if (!comm->gpu_flush.enabled) {
Expand Down
Loading