Skip to content

Remove unused imports and variables flagged in code review#4

Merged
MeighenBergerS merged 2 commits into
smb/version_2_0from
copilot/sub-pr-3
Jan 12, 2026
Merged

Remove unused imports and variables flagged in code review#4
MeighenBergerS merged 2 commits into
smb/version_2_0from
copilot/sub-pr-3

Conversation

Copilot AI commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Addresses code review comments identifying unused imports and variables across the codebase.

Changes

  • fennel/fennel.py: Remove unused JaxArray import (retain PRNGKey which is used)
  • fennel/photons.py: Remove unused JaxArray import
  • fennel/results.py: Remove unused JaxArray import block entirely
  • tests/test_integration.py: Remove unused Fennel, config imports and particle variable
  • tests/test_config.py: Remove unused yaml import

All removals verified safe - no references to removed symbols exist in affected files.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: MeighenBergerS <18549087+MeighenBergerS@users.noreply.github.com>
Copilot AI changed the title [WIP] Release v2.0.0 with new API and validation Remove unused imports and variables flagged in code review Jan 12, 2026
Copilot AI requested a review from MeighenBergerS January 12, 2026 16:09
@MeighenBergerS

Copy link
Copy Markdown
Owner

Removal of unused variables seems good. Merging

@MeighenBergerS MeighenBergerS marked this pull request as ready for review January 12, 2026 16:11
@MeighenBergerS MeighenBergerS merged commit a78c1c1 into smb/version_2_0 Jan 12, 2026
28 checks passed
@MeighenBergerS MeighenBergerS deleted the copilot/sub-pr-3 branch January 12, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants