Add options response seams and bump version to 0.2.0 - #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
fetchOptionsdoes more than fetch: it sequences requests, drops stale responses, and does the post-render bookkeeping. A host app whose options endpoint returns something other than a Turbo Stream currently has no way to change only the response handling — it has to reimplement the whole method and inherit the drift that comes with a copy.What
Two extension points, both with today's behaviour as their default:
Overriding them keeps the request sequencing, the stale response guard,
aria-busy,renderOptionsState, and single-option auto-selection in the base controller.And a third event, alongside
changeandadvanced-select:change:It fires after every successful remote load — eager dependent loads included — once the options are in the DOM and any auto-selection has been applied.
countis the number of selectable options, which is enough to react to an empty or single-option result without reading the DOM.