Add appendOption and replaceOptions to drive the option list - #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Host apps that load options outside the Turbo Stream flow have no way to add or replace them.
optionElementgave them the markup; this gives them the list.What
Both take options in the option contract shape and render them through
optionElement, so they carry the host's class map.appendOptionadds one option to the end and does nothing if that id is already present. It does not select it — that isaddOption, which belongs to Add Mode.replaceOptionsswaps the whole list. Leavingselectedout keeps the current selection even when the new list no longer contains it — the common case after a remote search, where the selected record can fall outside the page of results. Passingselectedassigns it withsetValuesemantics,nullincluded.It is silent by default, unlike
setValue: replacing a list is not a value change and should not cascade to dependent fields on its own.