Build option elements in the browser with the host class map - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The controller can only work with options the server rendered. Anything that needs to add or replace options in the browser — a host app reacting to a Turbo Stream, or the upcoming
appendOption/replaceOptions— has to build the option markup itself, and gets no access to the class map while doing it.What
The partial now publishes the resolved
option,option_check,option_content, andoption_descriptionclasses on the root element, alongside the ones already published there.optionElement(option)builds an option element from the option contract, producing the same markup asadvanced_select_option_tag— same role, aria state, action wiring, param attributes, and content structure, with classes taken from the host's class map rather than hardcoded: