[fix] addressed comments - #2
Merged
Merged
Conversation
MeherRushi
approved these changes
Jul 22, 2025
| ] | ||
| } | ||
| } | ||
| ~~~ |
Owner
There was a problem hiding this comment.
ok, I understand that the receiver's ability to reply in a certain format and it's capability for processing notifications of a certain format (which is the one it advertises) are different. Here, we seem to covering the reply format capability differences but not the receiver format capability right ?
Like based on the review:
A more meaningful response would be one where the receiver is only capable of receiving CBOR. Similarly, the other meaninful response would when it does not support CBOR. Can that example be added to the document?
Maybe we should include an example where encoding:cbor is not supported as well ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.