Fix: Duplicate funding reference add button

[McNamara84]

This pull request improves the user experience for adding funding references in the Data Editor by ensuring that only one clear "Add Funding Reference" action is visible at any time, regardless of whether the list is empty or contains items. It also updates and adds comprehensive tests to verify this behavior, and documents the change in the changelog.

User Interface Improvements:

• The FundingReferenceField component now displays a single "Add Funding Reference" button when the funding reference list is empty, and maintains a single list-level add button when references exist. This prevents duplicate prompts and clarifies the add action for users.

Testing Enhancements:

• Added and updated tests in funding-reference-field.test.tsx to ensure that:
  • Only one add action is shown when no references exist.
  • Only one add action is shown when references exist, and clicking it appends a new reference.
  • The UI returns to a single empty-state add action after all references are removed.
  • Tests updated to select the add button more robustly and avoid using array selectors. [1] [2]

Documentation:

• Added a changelog entry describing the improved add action behavior for funding references.
• Updated the API changelog test to assert the presence of the new entry.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[Copilot]

🟡 Changes recommended

The changelog test newly asserts a release date that is still in the future.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Prevents duplicate funding-reference add actions in the Data Editor and adds regression coverage.

Changes:

• Shows one context-appropriate add button.
• Tests empty, populated, and post-removal states.
• Documents the fix in the changelog.

File summaries

File	Description
funding-reference-field.tsx	Hides the list-level add button when empty.
funding-reference-field.test.tsx	Adds regression tests for add-action behavior.
ChangelogApiTest.php	Verifies the changelog entry.
changelog.json	Documents the UI fix.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 0
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.