Skip to content

Allow trailing comma in inline lists #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaybeJustJames merged 1 commit into from
Dec 8, 2025
Merged

Allow trailing comma in inline lists #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Yaml/Parser.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,14 @@ listInlineString =
listInlineNext : List Ast.Value -> Ast.Value -> P.Parser (P.Step (List Ast.Value) (List Ast.Value))
listInlineNext elements element =
P.oneOf
[ P.succeed (listInlineOnMore elements element)
|. P.chompIf U.isComma
[ P.succeed identity
|. P.symbol ","
|. U.whitespace
|= P.oneOf
[ P.succeed (listInlineOnDone elements element)
|. P.symbol "]"
, P.succeed (listInlineOnMore elements element)
]
, P.succeed (listInlineOnDone elements element)
|. P.chompIf U.isListEnd
]
Expand Down
8 changes: 8 additions & 0 deletions tests/TestParser.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,14 @@ suite =
ccc
]""" <|
Ast.List_ [ Ast.String_ "aaa", Ast.String_ "bbb", Ast.String_ "ccc ccc\n ccc" ]
, Test.test "an inline list with a trailing comma" <|
\_ ->
expectValue "[ aaa, bbb, ]" <|
Ast.List_ [ Ast.String_ "aaa", Ast.String_ "bbb" ]
, Test.test "an inline list with a trailing explicit null" <|
\_ ->
expectValue "[ aaa, bbb, null ]" <|
Ast.List_ [ Ast.String_ "aaa", Ast.String_ "bbb", Ast.Null_ ]
, Test.test "an inline list with an inline list inside" <|
\_ ->
expectValue "[ aaa, [ bbb, aaa, ccc ], ccc ]" <|
Expand Down