e3-g4: registry listing + EvaluationKit render (Gnosis) -- scoping finding - #57
Merged
Conversation
…ready correct for Gnosis (BION-DIRECTIVE-122)
Real scoping pass, not assumed: checked EvaluationKitEntry's real type
(@grey/schemas/evaluationKit/types.ts) directly -- it carries no
chain/address/network field at all, by design ("no hand-authored
per-platform metadata", every channel listing renders from this one
projection). MECH_OFFERING_SLUGS/mechPriceUsdFor don't vary by chain
either (D-106/107's own explicit decision to reuse Base's real tool/
pricing content for Gnosis). buildMechListing() itself has zero
Base-specific logic already.
Same real conclusion D-63 already reached for e3-b3 itself: "already
done, not a pending activation." Documented this finding directly in both
files rather than writing new code that isn't needed -- any real
per-chain distinction (which mech address a buyer actually pays) lives
entirely in config.ts's own chain-scoped constants and the real on-chain
registration, never in this render.
tsc --noEmit clean, vitest run 91 passed unchanged (doc/title-only change,
no behavior touched).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EvaluationKitEntry's real type directly -- carries no chain/address/network field at all, by design (single cross-channel projection). Offering slugs and pricing don't vary by chain either (D-106/107).buildMechListing()is already correct and complete for Gnosis, with zero code changes needed -- same real conclusion D-63 already reached for e3-b3 itself ("already done, not a pending activation").listing.ts's header andlisting.test.ts's title, rather than writing new code that isn't needed.Test plan
tsc --noEmitcleanvitest run: 91 passed, unchanged (doc/title-only change)Held for arc-end review, not merged.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LoiqDXzQQeejwguqcQFzBL