M6 Phase D — commit acp-node-v2 as adapter dependency (FDQ-69b) - #29
Merged
Conversation
FDQ-69 ruled (b): declare the ACP SDK as a real committed dependency so the box provisions it via a normal `pnpm install --filter @grey/acp-adapter...` (zero deploy drift), instead of a box-local `pnpm add` that would dirty the checkout. - adapters/acp-adapter/package.json: add "@virtuals-protocol/acp-node-v2": "^0.0.4". - pnpm-lock.yaml: resolve the SDK tree (@account-kit/@alchemy/@privy-io/socket.io/…). - pnpm-workspace.yaml: explicitly DECLINE the SDK's optional native websocket build scripts (bufferutil, utf-8-validate, es5-ext) — pure-JS fallbacks exist, so the adapter runs without them and the memory-tight VPS compiles no native code on install. (pnpm 11's deps-status check errors on undecided build scripts; declaring the decline clears it.) Build isolation preserved: sdk.ts loads the SDK via a variable-specifier dynamic import, so tsc never pulls it into the type graph even now that it's installed. Verified: typecheck + build green; tier-1 offline smoke green (still "no SDK"); 21 adapter tests pass. The heavy tree is a runtime/prod concern only (dev/CI installs now carry it; that was the accepted FDQ-69b trade). Not a code change to the adapter — dependency declaration only. Cutover (Task B) is gated on this merging + Forces opening the window. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Mayakovsky
added a commit
that referenced
this pull request
Jul 26, 2026
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M6 Phase D (Task A) — commit
acp-node-v2as an adapter dependency (FDQ-69b)FDQ-69 ruled (b): declare the ACP SDK as a real committed dependency so the box provisions it via a normal
pnpm install --filter @grey/acp-adapter...(zero deploy-checkout drift), rather than a box-localpnpm addthat would dirty the committed manifest. Dependency declaration only — no adapter code change.Changes (3 files)
adapters/acp-adapter/package.json— add"@virtuals-protocol/acp-node-v2": "^0.0.4"todependencies.pnpm-lock.yaml— resolve the SDK tree (@account-kit/@alchemy/@privy-io/socket.io/…).pnpm-workspace.yaml— explicitly decline the SDK's optional native websocket build scripts (bufferutil,utf-8-validate,es5-ext). They have pure-JS fallbacks, so the adapter runs without them and the memory-tight VPS compiles no native code on install. pnpm 11's deps-status check errors on undecided build scripts; declaring the decline clears it. (Necessary addition beyond the two paths named in the directive — flagged.)Build isolation preserved (the whole point of the Phase C posture)
sdk.tsloads the SDK via a variable-specifier dynamic import, sotscnever pulls it into the type graph even now that it's installed. Verified locally:pnpm -F @grey/acp-adapter typecheck— green.pnpm -F @grey/acp-adapter build— green.pnpm -F @grey/acp-adapter tier1-smoke— PASS, still reports "no SDK" (dynamic import unresolved at build).pnpm -F @grey/acp-adapter test— 21/21.The heavy tree is now a runtime/prod concern only; dev/CI installs carry it (the accepted FDQ-69b trade). The declined native builds are optional accelerators, not correctness-critical.
Sequencing
HOLD for merge. The cutover window (Task B) is gated on (1) this merging and (2) Forces opening the window:
pm2 stop grey→ filtered SDK install on the box → copy the 3ACP_*creds on-box →systemctl enable --now grey-acp-adapter→ tier-3 $0.25 proof job. Reversible throughout; wallet reused (Q6); never co-run.🤖 Generated with Claude Code