Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Windows managed processes now retain output and deliver completion reliably on Python 3.11/3.12. Capture no longer uses unavailable os.set_blocking or socket-only selectors on Windows pipes, and quiet polling uses high-resolution deadlines so clock granularity cannot cause extra scans.
Stacked on #133 (base
1ae80c50). Related to #124 and #126.Changes
The managed-process portions were adapted from PR #125 at
4189a990. That PR is unchanged; its separate Python-execution and file-writing work is not included.Validation
f90f5cc290e4393a3b09d18f4f840915b361f7a2, including native Windows 3.11/3.12, Linux/macOS process contracts, both Link-provider jobs, runtime, TUI, docs, and security checks. External CodeRabbit review was skipped.ACP integration and limits
Branch:
fix/windows-process-capture; head:f90f5cc290e4393a3b09d18f4f840915b361f7a2. If portability commit7505ee73and environment-policy follow-uped037b00are already integrated, take only the final timing commit.ProcessTools.bind/execute and process-event payload APIs are unchanged. No ACP files were edited.
Cleanup is not Windows Job Object ownership: detached descendants or descendants whose launching shell already exited are not guaranteed recoverable. Stopping local SSH does not guarantee remote termination. Output is decoded as UTF-8. Nothing was merged, deployed, or substituted for a running Penguin process.