Harden MCP execution sessions and add structured agent tools#44
Closed
MaxBittker wants to merge 2 commits into
Closed
Harden MCP execution sessions and add structured agent tools#44MaxBittker wants to merge 2 commits into
MaxBittker wants to merge 2 commits into
Conversation
Owner
Author
|
Superseded by the deliberately minimal #47, which keeps only per-bot execute_code FIFO/quiescence, scoped TypeScript/log execution, and CI coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Benchmark runs repeatedly lost output on timeout, continued mutating after tool cancellation, collided through concurrent calls, reused stale cached sessions, and failed on TypeScript syntax despite the tool claiming TypeScript support. This PR moves those guarantees into one tested execution/session layer.
inspect_state supersedes the older, narrower get_state proposal in #1.
Validation
bun test mcp: 23 tests pass, 62 assertionsbun x tsc --noEmit -p mcp/tsconfig.jsonbun sdk/test/chat-history.test.tsbun sdk/test/click-dialog-by-text.test.tsgit diff --checkKnown boundaries
Root tsc retains the two pre-existing banking nullability errors; PR #43 fixes those and adds repository-wide CI.