Improve UI - #24
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR overhauls the Mars Lander simulator’s frontend UI to better align with a new “mission control” layout and accessibility-focused standards, and adds a comprehensive Copilot guidance document for contributors.
Changes:
- Reworked the main HTML structure (sidebar onboarding + controls, main viewer, playback bar, loader, error banner) and rewrote the CSS into a smaller token-driven stylesheet.
- Refactored JS to use ES-module exports for WASM integration and simplified UI controller state/playback/tooltip logic.
- Added
.github/copilot-instructions.mdwith detailed architecture, UX, accessibility, and contribution guidelines.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
web/styles.css |
Replaced large legacy styles with tokenized, accessibility-oriented layout + component styles. |
web/index.html |
Restructured page into sidebar + main viewer, added onboarding content, playback controls, loader, and error banner. |
web/js/wasm-interface.js |
Simplified WASM init and exposed predefinedMaps + runMarsLanderSimulation as module exports. |
web/js/ui-controller.js |
Major rewrite: new playback model, tooltips, onboarding collapse, sidebar toggle, and run flow. |
.github/copilot-instructions.md |
Added comprehensive Copilot/project guidance and conventions. |
css/critical.css |
Removed critical CSS file. |
.gitignore |
Ignored .vscode. |
package-lock.json |
Lockfile metadata updates (peer flags). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…olons in comments and descriptions
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Deploying mars-lander with
|
| Latest commit: |
737f04c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c216acfe.mars-lander.pages.dev |
| Branch Preview URL: | https://improve-ui.mars-lander.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive project documentation for the Mars Lander simulator and makes some minor JavaScript and CSS changes to align with new standards and improve maintainability. The most significant addition is a detailed Copilot instructions file that covers architecture, tech stack, UX, accessibility, and design system guidelines.
Key changes:
Documentation & Project Standards
.github/copilot-instructions.mdfile containing an extensive project summary, tech stack details, architecture and contribution rules, UX guidelines, accessibility requirements, user research, and implementation priorities for Copilot suggestions. This document serves as a single source of truth for development and onboarding, emphasizing pedagogy, clarity, and accessibility.Frontend JavaScript
web/js/wasm-interface.jsto remove the version query parameter, simplifying the import statement.predefinedMapsinwasm-interface.jsto use an explicitexportstatement, making it available for import elsewhere in the codebase.Styling / Design Tokens
css/critical.css, including all CSS custom properties (design tokens), global layout, and critical UI styles. This suggests a migration or consolidation of critical CSS elsewhere, possibly to align with the new documentation or design system.