Refactor/income logic#22
Closed
colombefioren wants to merge 18 commits into
Closed
Conversation
colombefioren
commented
Aug 27, 2025
colombefioren
commented
Collaborator
- Now its perfect
- (Same as before) removed everything about income categories
- Followed very very well the spec
…date required in backend)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Mathieu-bot
reviewed
Aug 27, 2025
Mathieu-bot
left a comment
Mathieu-bot
left a comment
Owner
There was a problem hiding this comment.
- Always validate user input and handle errors on the server, even if the client already does it.
- This keeps our app secure, reliable, and easier to maintain.
Collaborator
Author
|
You're sooo right, I'll integrate it in a future PR |
Owner
|
I'm talking about the income amount and the income date, but this applies
to all inputs
…On Wed, Aug 27, 2025, 10:21 PM COCO ***@***.***> wrote:
*colombefioren* left a comment (Mathieu-bot/expense-tracker#22)
<#22 (comment)>
Are you talking about one input in particular ?
—
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BPVDIT3VMRKPXLVFH2AITRD3PYANPAVCNFSM6AAAAACE66LBVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMRZGQ3TCMJZGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.