feat(skills): automate milestone merge readiness#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
plan-promptsandmilestone-runnerskills so milestone execution can run autonomously through merge when all gates are clear.The prior contract stopped milestone runs at "PR stack open, checks green, reviewed, ready for human review" unless the user separately authorized a merge. That made the runner safe, but it prevented the intended unattended flow where each milestone stack reaches a clear merge decision and the orchestrator continues after verifying the result.
This branch changes the contract to a structured
GO/NO-GOhandoff:plan-promptsnow requires every generated milestone/goalblock to end with a finalGOorNO-GOverdict plus evidence.milestone-runnernow treats that verdict as a required gate before advancing.GOverdict plus independently verified external gates authorizes automatic root-to-leaf stack merge and branch cleanup.NO-GO, missing/ambiguous verdicts, pending/failing checks, failed verification, wrong branch topology, explicit no-merge requests, or aHUMAN REVIEW GATEstop the sequence.Scope
skills/milestone-runnerGOplus external gate verification.Stack verdictgate: the final milestone output must containGOwith evidence before merge, whileNO-GO, missing verdicts, or ambiguous verdicts stop the sequence.main.HUMAN REVIEW GATEmilestones.GO, and explicit merge requests are treated asGOcandidates only when gates are green.skills/plan-promptsDONEincludes a finalGO/NO-GOmerge verdict with evidence.FINAL VERDICTsection to every generated milestone/goaltemplate.GOnarrowly: every PR open, correctly based, reviewed, green, locally verified, and the whole stack satisfies every milestone acceptance row.NO-GOfor failing/pending checks, incomplete review, wrong topology, missing verification, scope leakage, remaining human/manual gates, or ambiguous merge readiness.GO/NO-GOmerge-readiness language.Skill Evaluator Results
Verification
Observed results:
Checklist
SKILL.mdhas valid YAML frontmatter withnameanddescriptionSKILL.mdresolve to existing files