Fix formula text truncated on XML character references#348
Open
sentinelt wants to merge 1 commit into
Open
Conversation
quick-xml emits numeric character references (e.g. –) as GeneralRef events between Text fragments. DataValidation and Formula parsers replaced the accumulator on each Text event and ignored GeneralRef, so list formulas were truncated to the last fragment. Append Text and GeneralRef instead, with unit coverage for en-dash list formulas. Also close a missing brace in number_formater tests that broke compilation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataValidation/ formula character data that contains XML numeric character references (e.g.–for an en-dash) was truncated when reading.xlsxfiles.Root cause
quick-xml emits those references as
Event::GeneralRefnodes between successiveEvent::Textfragments. The parsers forDataValidation(formula1/formula2) andFormulareplaced the accumulator on eachTextevent and ignoredGeneralRef, so only the last text fragment survived.Example list formula in a real workbook:
was read as:
instead of the full list string.
Fix
Textevents instead of overwritingGeneralRef(numeric char refs + common named entities)append_xml_text/append_xml_general_refnumber_formatertests that broke compilation of the local tree