fix: stop appending sandbox switches after startup - #1007
Open
OneNoted wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've hit this on three Arch machines using Wayland, with Niri and Hyprland. With a fresh profile, TIDAL opens a blank player and child processes crash.
On this machine I'm running kernel
7.2.2-arch1-1, TIDAL Hi-Fi8.1.3, and Castlabs Electron43.0.0+wvcus. I reproduced it with both AUR packages (tidal-hifi-binandtidal-hifi-git) and from source.TIDAL appends
no-sandboxanddisable-seccomp-filter-sandboxafter Electron has started its Linux zygotes. This appears to leave processes with inconsistent sandbox state.This removes those late switches and keeps the saved setting using the existing renderer sandbox preferences. Passing
--no-sandboxat launch still works. The settings text and troubleshooting docs explain the distinction.Lint and the package build pass. I tested source and packaged builds with the renderer sandbox setting on and off. After clearing the local profile and caches, the patched build downloaded Widevine and loaded the TIDAL home page without new crashes. Signed-in playback also works. I haven't tested other operating systems.