Skip to content

docs: fix ECC capabilities table - #67

Merged
keldonin merged 3 commits into
Mastercard:masterfrom
domodwyer:dom/fix-doc-tables
Jul 29, 2025
Merged

docs: fix ECC capabilities table#67
keldonin merged 3 commits into
Mastercard:masterfrom
domodwyer:dom/fix-doc-tables

Conversation

@domodwyer

Copy link
Copy Markdown
Contributor

Fixes the broken pkcs11info table rendering for ECC capabilities: https://github.com/Mastercard/pkcs11-tools/blob/master/docs/MANUAL.md#p11slotinfo

The f192a44 commit was the result of the automatic formatting by my editor but I included it as it fixes some minor stray spaces. Happy to drop the commit though 👍


  • docs: reformat table alignment (f192a44)

  • docs: fix ECC capabilities table (6a5e4ba)

    Fix the ECC capabilities markdown table so it renders correctly.
    

Fix the ECC capabilities markdown table so it renders correctly.
Comment thread docs/MANUAL.md Outdated
Comment on lines +274 to +275
| `unc` | Supports compressed points representation |
| `cmp` | Supports compressed points representation |

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The descriptions for unc and cmp are the same.

I suspect unc should say:

Supports uncompressed points representation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @domodwyer, yes it should. Can you adjust your PR to reflect the change? As far as I can see it is left to "compressed". Many thanks!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I didn't changed it until confirmed - I've pushed f5838c8 that corrects this now 👍

@keldonin keldonin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @domodwyer for your contribution. Please check the comments and adjust your PR.

:-)

Comment thread docs/MANUAL.md Outdated
Comment on lines +274 to +275
| `unc` | Supports compressed points representation |
| `cmp` | Supports compressed points representation |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @domodwyer, yes it should. Can you adjust your PR to reflect the change? As far as I can see it is left to "compressed". Many thanks!

This looks to be a copy / paste mistake.
@keldonin
keldonin merged commit 28f3abf into Mastercard:master Jul 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants