Admin Phase 3, slice 1: staged-edits API over ADMIN_DB + insert-only action-audit tripwire#55
Merged
Conversation
…ce 1a) worker/admin/staging.ts: the D1 layer for staged catalog/content edits over the separate ADMIN_DB (migrations-admin/0001) — list (metadata only, never draft bodies), get, create, update, abandon. Every mutation batches its row with an INSERT into admin_action_audit atomically; the audit detail column carries tokens derived from validated enums only, never free text. Rows age out via a 30-day TTL that slides on update and deliberately not on abandon; there is no hard DELETE. Like roster.ts, every DB failure throws so the routes surface an explicit 5xx. AdminEnv + the worker Env gain the optional ADMIN_DB binding (absent ⇒ the staging routes fail closed with 503). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LVPyHAtQ1cdK76RpFasafP
…se-3 slice 1b) Five routes: list (GET), get (GET ?id), create/update/abandon (POST). The superadmin-only management gate generalizes to requireActor(minRole) — one gate, both auth paths (cookie + per-request NIP-98), per-request role re-derivation, CSRF on every mutation, its own admin-staging rate bucket; requireSuperadmin stays as a thin wrapper so the roster routes are unchanged. Scoping: admins operate on their OWN drafts — another author's draft reads as 404, indistinguishable from nonexistent (no oracle). Superadmins list/read/ abandon any draft (janitorial) but can never update another author's words (explicit 403; they can already see the row, so honesty beats a fake 404). Closed drafts (abandoned / future pr-opened) reject mutation with 409. The NIP-98 u-tag for get covers the query string — the id is part of what was signed. Missing ADMIN_DB ⇒ explicit 503; unreachable ⇒ 503, never an empty 200 pretending the store is fine. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LVPyHAtQ1cdK76RpFasafP
…t pin 17 tests pinning the LOOP.md journeys by name: J1 cookie happy path; J2 fails-closed matrix (401 non-member == 401 bad signature, 503 missing AND unreachable ADMIN_DB, 403 CSRF, 403 cross-site, 429 rate-limited, 404 wrong method); J3 author scoping incl. the superadmin update-others 403; J4 validation + lifecycle (400s write zero audit rows; closed drafts 409; expired rows invisible); J5 exact audit rows per mutation + the static tripwire extending the 0002 contract to admin_action_audit across every worker/admin module; J6 per-request NIP-98 with replay burn + u-tag mismatch. Same harness discipline as the other admin suites: in-memory fakes, real schnorr, the real AdminCoordinator, the compile-time deps seam. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LVPyHAtQ1cdK76RpFasafP
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
wecanjustbuildthings | e8d703b | Jul 11 2026, 07:49 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The first server slice against the now-provisioned
ADMIN_DB(#54) — three commits, one logical change each:f0d78a2— data layer (worker/admin/staging.ts): list (metadata only — never draft bodies), get, create, update, abandon overstaged_edits; every mutation batches its row atomically with an INSERT intoadmin_action_audit(detail column carries validated-enum tokens only, never free text). 30-day TTL slides on update, deliberately not on abandon; no hard DELETE.AdminEnv/workerEnvgain the optionalADMIN_DBbinding (absent ⇒ 503, fails closed).0441251— routes (/api/admin/staging*, five of them): the superadmin management gate generalizes torequireActor(minRole)— one gate, both auth paths (cookie+CSRF / per-request NIP-98 with replay burn), per-request role re-derivation, ownadmin-stagingrate bucket. Scoping: admins touch only their own drafts (cross-author reads as 404 — no existence oracle); superadmins list/read/abandon any draft but can never update another author's words (explicit 403). Closed drafts reject with 409. The NIP-98utag forgetcovers the query string.e8d703b— tests: 17 new tests pinning the journeys by name (J1–J6), including the static insert-only tripwire extending the 0002 audit contract toadmin_action_auditacross every worker/admin module.Built under a build→verify loop with executed evidence for every claim: full suite 352/352,
verify:allgreen,wrangler deploy --dry-runresolvesenv.ADMIN_DB, and a livewrangler devsmoke against a local D1 (migration applied; unauth → generic 401 with zero set-cookie; unknown route → 404).Not in this slice (next): enforcement-engine wiring for drafts, the publish→PR path, console UI, moderation routes.
Type of change
Required checks
npm run checkpassesnpm run enforcepasses (zero new dependencies)npm testpasses — 352/352 (+17 this slice)npm run buildsucceeds (fullverify:allgreen)Security posture
ADMIN_DBis an explicit 503, never an empty 200; non-member 401 is indistinguishable from bad-signature 401; cross-author 404 is indistinguishable from nonexistent.admin_action_auditis INSERT-only by contract, pinned statically in tests — an editable audit trail is theater.🤖 Generated with Claude Code
https://claude.ai/code/session_01LVPyHAtQ1cdK76RpFasafP
Generated by Claude Code