Fix incomplete boards list rendering - #625
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the hardware boards pages https://marlinfw.org/docs/hardware/boards.html#boards-list so the complete list from
_data/boards.ymlis rendered.What was found
MINIRAMBOand the later board groups were present and valid in the YAML data. The board-name<code>tag in the Liquid template was only closed for entries with a legacy board name. This produced malformed HTML, which caused Kramdown to stop rendering the list correctly after the early groups.Changes
Close the primary board-name
<code>tag for every board before conditionally rendering the legacy board name.Verification
BOARD_MINIRAMBO.