Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a “Recently Used” submenu to the editor font picker, allowing users to quickly re-select fonts they’ve used recently without opening the full font browser/panel.
Changes:
- Introduces a new localized string for the “Recently Used” menu item.
- Extends
FontPickerConfigurationto supply the new menu title and renames the font-panel title parameter for menu-item consistency. - Implements recent-font discovery via
NSFontCollection(name: .recentlyUsed)and displays those entries in theFontPickermenu.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MarkEditMac/Sources/Settings/EditorSettingsView.swift | Wires new configuration titles into the app’s settings font picker configuration. |
| MarkEditMac/Sources/Main/AppResources.swift | Adds Localized.Settings.recentlyUsed string constant. |
| MarkEditMac/Resources/Localizable.xcstrings | Adds translations for the new “Recently Used” localization key. |
| MarkEditMac/Modules/Sources/FontPicker/FontPickerConfiguration.swift | Adds recentlyUsedItemTitle and renames openPanelButtonTitle → openPanelItemTitle. |
| MarkEditMac/Modules/Sources/FontPicker/FontPicker.swift | Adds the “Recently Used” submenu populated from recent font families. |
| MarkEditMac/Modules/Sources/AppKitExtensions/UI/NSFont+Extension.swift | Adds NSFont.recentFamilyNames(maxCount:) helper backed by the .recentlyUsed font collection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.