Unclickable buttons while WASM module loads - #15
Open
HeCorr wants to merge 3 commits into
Open
Conversation
decided to do it all in JS land not to pollute the HTML file too much. tho maybe I should at least leave them disabled there in case the JS file itself takes a bit to load on REALLY slow connections.
Contributor
Author
|
Oops, I had completely forgotten about this PR. @MarinX any thoughts on it's current state? |
using a very ugly css trick to change the button text while it has the `wasm-init` class, which gets removed when the module is initialized. buttons also start disabled now.
Contributor
Author
|
Okay that is significantly better. Ready to be reviewed. |
HeCorr
marked this pull request as ready for review
August 12, 2026 02:04
Owner
|
Thanks for PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14.
This PR temporarily disables all submit buttons until the WASM module finishes loading to prevent some issues, also changing the buttons' text to indicate that.