Repository navigation
Build Csla.Maui Release against the CSLA 11 prerelease package - #4971
Merged
Merged
Conversation
The shared XAML code now uses v11-only APIs (Csla.Mvvm.ViewModel<T> and TrimmingMessages), so the Release build, which release-maui packs, failed on every target framework against the Csla 10.0.0 package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .NET 11 MAUI targets were added in #4922, but the Release configuration of
Csla.Xaml.Maui(whatrelease-maui.yamlpacks intoCsla.Maui) still compiled against theCsla10.0.0 NuGet package. The shared XAML code now uses v11-only APIs (Csla.Mvvm.ViewModel<T>from #4960 andTrimmingMessagesfrom #4962), so the Release build failed on every target framework with 16 errors.Changes
Csla.Xaml.Mauireferences theCsla11.0.0-alpha.1 prerelease package instead of 10.0.0. This follows the v10 pattern (a Csla prerelease during development, switched to the released version at ship time as in Target released CSLA 10 package #4808), so it will move to11.0.0when CSLA 11 ships.Testing
dotnet build Source/csla.maui.build.sln -c Release: 0 errors, 0 warnings on all 8 TFMs (net10.0/net11.0 × android, ios, maccatalyst, windows); previously 16 errorsdotnet pack Source/csla.maui.build.sln -c Release -p:PublicRelease=true: producesCsla.Maui.11.0.0-alpha.1.nupkg, depending onCsla11.0.0-alpha.1 for every target groupdotnet build Source/csla.maui.build.sln -c Debug: still 0 errors, 0 warningsCloses #4924
🤖 Generated with Claude Code