feat: add layer deletion schemas, types and constants (MAPCO-7285)#210
Merged
Conversation
CL-SHLOMIKONCHA
requested changes
Jun 28, 2026
|
|
||
| export const DeletionTaskTypes = { | ||
| Delete: 'delete', | ||
| LayerTilesDeletion: 'full-layer-tiles-deletion', |
Contributor
There was a problem hiding this comment.
keep as 'tiles-deletion' as the job type itself is "Delete-Layer"
Collaborator
Author
There was a problem hiding this comment.
Changed to tiles-deletion
CL-SHLOMIKONCHA
requested changes
Jun 28, 2026
|
|
||
| export const artifactsDeletionParamsSchema = z | ||
| .object({ | ||
| sourceProvider: sourceProviderSchema, |
Contributor
There was a problem hiding this comment.
add optional "bucket" param
CL-SHLOMIKONCHA
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: MAPCO-7285
Further information:
Adds the shared
deletionmodule for the layer deletion feature, exported from theconstants,schemasandtypesbarrels.DeletionJobTypes(Delete_Layer) andDeletionTaskTypes(delete,full-layer-tiles-deletion,artifacts-deletion).deleteLayerJobParamsSchema,deleteTaskParamsSchema,layerTilesDeletionParamsSchema,artifactsDeletionParamsSchema(and the sharedsourceProviderSchemaover the existing coreSourceType).DeleteLayerJobParams,DeleteTaskParams,LayerTilesDeletionParams,ArtifactsDeletionParamsinferred from the schemas.