Skip to content

Death Link Description Fix - #224

Merged
silasary merged 1 commit into
ManualForArchipelago:mainfrom
Nixill:Fix-DeathLink
Jul 30, 2026
Merged

Death Link Description Fix#224
silasary merged 1 commit into
ManualForArchipelago:mainfrom
Nixill:Fix-DeathLink

Conversation

@Nixill

@Nixill Nixill commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

When using options.json to modify the death_link option, Manual copies Archipelago' DeathLink class itself to the manual_options dict. It is this class that gets modified when, say, adding a description to the option. Since Archipelago's base class is modified, the modification is copied to all of the player's other APWorlds.

For example, my description from Manual_LEGORacers2_Nixill:

  death_link:
    # Enable death link?
    # 
    # Send a death whenever you lose, reset, or leave any race or minigame,
    # or if your game crashes.
    # 
    # If you receive a death during a race or minigame, restart that race or
    # minigame immediately.
    'false': 50
    'true': 0

... can be seen in A Link to the Past:

  death_link:
    # Enable death link?
    # 
    # Send a death whenever you lose, reset, or leave any race or minigame,
    # or if your game crashes.
    # 
    # If you receive a death during a race or minigame, restart that race or
    # minigame immediately.
    'false': 50
    'true': 0

... or Blasphemous:

  death_link:
    # Enable death link?
    # 
    # Send a death whenever you lose, reset, or leave any race or minigame,
    # or if your game crashes.
    # 
    # If you receive a death during a race or minigame, restart that race or
    # minigame immediately.
    # 
    # Note that Guilt Fragments will not appear when killed by death link.
    'false': 50
    'true': 0

... or other Manuals like Euro Truck Simulator 2:

  death_link:
    # Enable death link?
    # 
    # Send a death whenever you lose, reset, or leave any race or minigame,
    # or if your game crashes.
    # 
    # If you receive a death during a race or minigame, restart that race or
    # minigame immediately.
    'false': 50
    'true': 0

This pull request fixes that by creating a subclass of DeathLink and modifying that instead.

@nicopop nicopop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks logical

@nicopop
nicopop requested a review from silasary July 29, 2026 21:45

@silasary silasary left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@silasary
silasary merged commit 48d3f63 into ManualForArchipelago:main Jul 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants