Item/location description in the client - #219
Draft
nicopop wants to merge 23 commits into
Draft
Conversation
…lotdata if possible
…into client-misc-changes
Contributor
|
These fields should populate |
Contributor
Author
@silasary |
Contributor
Author
|
webworld.location/item_descriptions are dict[str (name), str(desc)] |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Used to be part of #214 now standalone and with a real implementation with it
it will require #214 to be merged before this one since this branch is based on it
Added for both items.json and locations.json:
descriptionSomeone that knows more about kivy could potentially move the description below the item/location name but thats not something I know how to do other than maybe adding a \n
The following example pictures shows my Old OuterWilds manual using those aliases to protect against spoilers
