Fix for place_item and local item not being done at the right time during gen - #215
Open
nicopop wants to merge 9 commits into
Open
Fix for place_item and local item not being done at the right time during gen#215nicopop wants to merge 9 commits into
nicopop wants to merge 9 commits into
Conversation
silasary
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple things that AP's Unit tests says we are to late in generation
create_itemsgenerate_earlyMoving the item placement made the after_generate_basic hook useless so I removed it
and added a before_create_items_place_items instead
To make sure we catch everything like this in the future I added test location and items that each test a property we hadn't tested before