Only capture metrics for supported ContainerImages - #21829
Merged
Fryguy merged 1 commit intoApr 26, 2022
Merged
Conversation
Member
Author
|
Member
Author
|
We have this handy supports feature already https://github.com/ManageIQ/manageiq/blob/master/app/models/metric/ci_mixin.rb#L23-L28 and the |
agrare
force-pushed
the
only_capture_metrics_supported_container_images
branch
from
April 22, 2022 13:29
c211c64 to
cc482fa
Compare
Member
|
Checked commit agrare@cc482fa with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint |
Member
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
May 9, 2022
…container_images Only capture metrics for supported ContainerImages (cherry picked from commit 32750cf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenShift provider collects a mixture of ContainerImages some of which support metrics capture and some which do not. We have an issue with ContainerImage class names (#21828) but even with that fixed fundamentally we are trying to capture metrics from ContainerImages which do not support it.
Fixes #21825