Skip to content

Experiments with select#54

Open
Malkovsky wants to merge 3 commits into
mainfrom
feature/select_implementations
Open

Experiments with select#54
Malkovsky wants to merge 3 commits into
mainfrom
feature/select_implementations

Conversation

@Malkovsky

Copy link
Copy Markdown
Owner

No description provided.

@Malkovsky Malkovsky requested a review from Sanya239 June 8, 2026 19:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4a302e8501

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CMakeLists.txt
Comment on lines +178 to +179
add_executable(select512_experimental_tests
src/tests/select512_experimental_tests.cpp)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Wire the new select tests into CI

This adds a new test binary, but the test suite is not registered with CTest and the checked CI workflow .github/workflows/build-test.yml runs only the existing binaries explicitly (./unittests, ./louds_tree_tests, ./dfuds_tree_tests, ./benchmark_tests, and ./test_rmm, with the SDE job following the same pattern). As a result, regressions caught by select512_experimental_tests will not fail CI unless someone runs this target manually; please add this executable to the workflow or register it via CTest and run ctest.

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.19%. Comparing base (7445639) to head (7109637).

Files with missing lines Patch % Lines
src/tests/unittests.cpp 87.75% 2 Missing and 4 partials ⚠️
include/pixie/bits.h 84.61% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   89.22%   89.19%   -0.04%     
==========================================
  Files          17       17              
  Lines        4556     4617      +61     
  Branches      828      840      +12     
==========================================
+ Hits         4065     4118      +53     
- Misses        284      287       +3     
- Partials      207      212       +5     
Flag Coverage Δ
gcov 89.19% <86.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant