Experiments with select#54
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a302e8501
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| add_executable(select512_experimental_tests | ||
| src/tests/select512_experimental_tests.cpp) |
There was a problem hiding this comment.
Wire the new select tests into CI
This adds a new test binary, but the test suite is not registered with CTest and the checked CI workflow .github/workflows/build-test.yml runs only the existing binaries explicitly (./unittests, ./louds_tree_tests, ./dfuds_tree_tests, ./benchmark_tests, and ./test_rmm, with the SDE job following the same pattern). As a result, regressions caught by select512_experimental_tests will not fail CI unless someone runs this target manually; please add this executable to the workflow or register it via CTest and run ctest.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 89.22% 89.19% -0.04%
==========================================
Files 17 17
Lines 4556 4617 +61
Branches 828 840 +12
==========================================
+ Hits 4065 4118 +53
- Misses 284 287 +3
- Partials 207 212 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.