Conversation
Malkovsky
requested changes
Nov 3, 2025
Malkovsky
left a comment
Malkovsky
left a comment
Owner
There was a problem hiding this comment.
For the baseline this is fine but the code should be refactored for readability.
Owner
|
For the part of functionality that intersects with bitvector (i.e. rank1/select1) please run the class against the corresponding tests |
Malkovsky
requested changes
Nov 7, 2025
Malkovsky
left a comment
Malkovsky
left a comment
Owner
There was a problem hiding this comment.
Ok, few changes needed to be made here. There are also others things, we'll probably go through them manually after the merge.
Malkovsky
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.