Implementation on AVX2#4
Merged
Merged
Conversation
All SIMD moved to bits.h
Malkovsky
requested changes
Oct 26, 2025
Malkovsky
left a comment
Malkovsky
left a comment
Owner
There was a problem hiding this comment.
Need AVX2 check in the same manner as with AVX-512
Owner
There was a problem hiding this comment.
Please make an analogue of AVX512SUPP for AVX2, it is not supported everywhere
Malkovsky
reviewed
Oct 26, 2025
| /** | ||
| * @brief Compare 4 64-bit numbers of @p x with @p y and | ||
| * return the length of the prefix where @p y is less then @p x | ||
| */ |
Owner
There was a problem hiding this comment.
Docsting should be next above the function declaration
Malkovsky
reviewed
Oct 26, 2025
|
|
||
| #else | ||
|
|
||
| uint64_t select_512(const uint64_t* bits, uint64_t rank) { |
Owner
There was a problem hiding this comment.
Please make it so the signature only appears once
Malkovsky
reviewed
Oct 26, 2025
|
|
||
|
|
||
| /** | ||
| * TODO: compile/runtime checks fror SIMD |
Malkovsky
approved these changes
Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All SIMD moved to bits.h