refactor(homepage): eliminate styles.css for full Tailwind migration#1085
Open
orveth wants to merge 1 commit into
Open
refactor(homepage): eliminate styles.css for full Tailwind migration#1085orveth wants to merge 1 commit into
orveth wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Rebased onto post-monorepo master; paths relocated app/ -> apps/web-wallet/app/. Original commits: - refactor(homepage): move easy CSS rules to Tailwind utilities (phase 1) - refactor(homepage): inline font-mono + swap ::before pseudos for sibling divs (phase 2) - refactor(homepage): replace ancestor-state animation triggers with data-state + group-data variants (phase 3) - refactor(homepage): delete styles.css after full Tailwind migration (phase 4)
72b3141 to
3f3ff41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental follow-up to #1050: deletes app/features/homepage/styles.css entirely and moves all rules into Tailwind utilities, JSX attrs, or arbitrary values. Diff is 4 phases (one commit each) for bisectability.
Phases
Verification
Pixel-perfect Chromium-verified at 1280×800, 768×1024, 390×844 against the homepage/v2-redesign baseline. All static regions: 0px diff. Residual diff confined to non-deterministic content (hero card carousel index + buy state-machine cycle phase). All 8 animations runtime-verified to fire with matching durations/easings.
font-mono scoping confirmed safe: outside .marketing tree, font-mono still resolves to default ui-monospace (verified on /signup).
Trade-offs surfaced
Pre-existing bugs surfaced (NOT introduced here, present on both branches)
iOS caveat
Verification is Chromium-on-Linux only. Arbitrary [filter:...] chains and font-feature settings all use standard CSS WebKit supports, but pixel-identical Safari rendering not confirmed without iOS hardware.
Co-Authored-By: orveth orveth@users.noreply.github.com