feat: revert total-Learning WIP cap due to issues with new-word intak…#24
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the “total-Learning WIP cap” behavior in the vocab test session selector after it caused “empty sessions” on large, pre-existing decks, restoring the earlier due-Learning-only throttling (learningCapForNew). It also documents the revert in the project task log and overview.
Changes:
- Removed
learningWipCapfromPriorityConfigand eliminatedwipPressure/newCeilinglogic, reverting to a single due-Learning-basedpressure. - Updated task-014 to
status: revertedwith an explanation and reproduction details. - Updated the project overview to reflect the reverted status and rationale.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/modules/vocab-test/selectors/PrioritySessionSelector.ts | Removes total-Learning WIP throttle and restores due-Learning-only intake scaling. |
| .project/tasks/task-014_cap-new-word-intake.md | Marks task as reverted and documents the reason/repro. |
| .project/overview.md | Updates goal/task status to “reverted” with a short note. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
84
to
88
| const used = new Set(picked.map((c) => c.item.rowNumber)); | ||
| let newsPicked = picked.filter((c) => isNew(c.item)).length; | ||
| for (const c of candidates) { | ||
| if (picked.length >= size) break; | ||
| if (used.has(c.item.rowNumber)) continue; | ||
| if (isNew(c.item)) { | ||
| if (newsPicked >= newCeiling) continue; | ||
| newsPicked++; | ||
| } | ||
| picked.push(c); | ||
| if (!used.has(c.item.rowNumber)) picked.push(c); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e management