feat: implement TopBarClient component for responsive navigation and …#17
Merged
Conversation
…user menu integration
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a responsive, session-aware top app bar by splitting the top bar into a server wrapper (for auth/session rendering) and a client component (for mobile menu state), while also fixing mobile horizontal overflow in the SRS tuning settings UI.
Changes:
- Introduced
TopBarClientto manage responsive navigation (hamburger menu on mobile) and close behavior (route change, outside click, Escape). - Updated
TopBarto a server wrapper that rendersUserMenuand slots it into the client bar. - Adjusted SRS tuning
SettingsPanellayout to wrap on narrow screens (save bar + seconds rows) and reduce padding/field widths to prevent sideways scrolling.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/vocab-test/components/SettingsPanel.tsx | Prevents mobile horizontal overflow by allowing wrapping and tightening spacing/widths. |
| src/components/TopBarClient.tsx | New client-side responsive top bar with mobile menu state + close interactions. |
| src/components/TopBar.tsx | Server wrapper that passes the session-aware UserMenu into TopBarClient. |
| src/components/NavLinks.tsx | Adds vertical layout + onNavigate callback to support the mobile menu. |
| .project/tasks/task-011_expose-srs-tuning-config.md | Documents the mobile overflow fix and verification notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…user menu integration