Add Cinematic & Film preset sections and extend filter/slider stack - #5
Add Cinematic & Film preset sections and extend filter/slider stack#5MahanKenway wants to merge 1 commit into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
digi-rawr | 8dd5995 | Feb 21 2026, 01:42 AM |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8dd5995983
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const amount = ((Math.abs(max - avg) * 2) / 255) * (filters.vibrance / 100) | ||
| r += (max - r) * amount | ||
| g += (max - g) * amount | ||
| b += (max - b) * amount |
There was a problem hiding this comment.
Make negative vibrance reduce saturation
The vibrance adjustment always pulls non-max channels toward the max channel (channel += (max - channel) * amount), so when filters.vibrance is negative, amount is negative and those channels are pushed farther away instead of toward neutral. In practice this means presets/sliders using negative vibrance (for example the new film presets) become more saturated and clip colors rather than desaturating, which is the opposite of expected behavior for a negative vibrance control.
Useful? React with 👍 / 👎.
Motivation
Description
FilterSettingsand addedDEFAULT_FILTERS,FILTER_SLIDER_CONFIG, andFILTER_ORDERto centralize defaults and slider metadata, and switchedsetFilters/reset logic to useDEFAULT_FILTERSfor deterministic behavior (changes live insrc/App.tsx).cinematicandfilmand four new presets:Cinematic Teal,Neon Nightdrive,Disposable Cam 2004, andMatte Film Dust, and updated the Presets UI to render new "Cinematic" and "Film & Disposable" sections.exposure,gamma,vibrance,temperature/tint, hue viaapplyHueShift, highlights/shadows tone mapping,fadeblending, asharpnesshigh-pass pass, and aclamphelper used when writing image data.stickerIdRef,getCanvasPointcoordinate mapping, hit-testing viahandleCanvasMouseDown, functionalsetStickersupdates for add/remove/drag, and keyboard handlers thatpreventDefaultfor arrow keys while moving stickers.Testing
npm run lintand the linter completed successfully.npm run buildand the build succeeded.npm run dev -- --host 0.0.0.0 --port 4173and verified the app served successfully.Codex Task