Skip to content

Add Cinematic & Film preset sections and extend filter/slider stack - #5

Open
MahanKenway wants to merge 1 commit into
mainfrom
codex/fix-project-bugs-and-add-filters-5k94u8
Open

Add Cinematic & Film preset sections and extend filter/slider stack#5
MahanKenway wants to merge 1 commit into
mainfrom
codex/fix-project-bugs-and-add-filters-5k94u8

Conversation

@MahanKenway

Copy link
Copy Markdown
Owner

Motivation

  • Provide additional discoverable preset buckets for cinematic and film looks and expand per-pixel tonal controls so presets can produce more natural and varied results.
  • Improve sticker interaction reliability (hit-testing, dragging and keyboard control) so canvas edits don't suffer from stale state.

Description

  • Extended FilterSettings and added DEFAULT_FILTERS, FILTER_SLIDER_CONFIG, and FILTER_ORDER to centralize defaults and slider metadata, and switched setFilters/reset logic to use DEFAULT_FILTERS for deterministic behavior (changes live in src/App.tsx).
  • Added new preset style values cinematic and film and four new presets: Cinematic Teal, Neon Nightdrive, Disposable Cam 2004, and Matte Film Dust, and updated the Presets UI to render new "Cinematic" and "Film & Disposable" sections.
  • Implemented several per-pixel operations and helpers: exposure, gamma, vibrance, temperature/tint, hue via applyHueShift, highlights/shadows tone mapping, fade blending, a sharpness high-pass pass, and a clamp helper used when writing image data.
  • Improved sticker handling with a stable incremental stickerIdRef, getCanvasPoint coordinate mapping, hit-testing via handleCanvasMouseDown, functional setStickers updates for add/remove/drag, and keyboard handlers that preventDefault for arrow keys while moving stickers.

Testing

  • Ran npm run lint and the linter completed successfully.
  • Built a production bundle with npm run build and the build succeeded.
  • Launched the dev server with npm run dev -- --host 0.0.0.0 --port 4173 and verified the app served successfully.
  • Captured an automated Playwright screenshot of the running app to validate UI changes and the screenshot generation completed successfully.

Codex Task

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Feb 21, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
digi-rawr 8dd5995 Feb 21 2026, 01:42 AM

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8dd5995983

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/App.tsx
Comment on lines +483 to +486
const amount = ((Math.abs(max - avg) * 2) / 255) * (filters.vibrance / 100)
r += (max - r) * amount
g += (max - g) * amount
b += (max - b) * amount

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Make negative vibrance reduce saturation

The vibrance adjustment always pulls non-max channels toward the max channel (channel += (max - channel) * amount), so when filters.vibrance is negative, amount is negative and those channels are pushed farther away instead of toward neutral. In practice this means presets/sliders using negative vibrance (for example the new film presets) become more saturated and clip colors rather than desaturating, which is the opposite of expected behavior for a negative vibrance control.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant