Fix canvas interaction bugs and add advanced photo filters - #4
Fix canvas interaction bugs and add advanced photo filters#4MahanKenway wants to merge 3 commits into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
digi-rawr | de98a62 | Feb 21 2026, 01:40 AM |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e84cfc40ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| r += (max - r) * amount | ||
| g += (max - g) * amount | ||
| b += (max - b) * amount |
There was a problem hiding this comment.
Flip vibrance delta so positive values increase saturation
The vibrance adjustment currently pushes each channel toward the dominant channel when filters.vibrance is positive (r/g/b += (max - channel) * amount), which narrows channel differences and desaturates the image; negative vibrance values do the opposite. This makes the Vibrance slider and any preset with vibrance > 0 behave opposite to user expectation (higher vibrance produces flatter colors).
Useful? React with 👍 / 👎.
Motivation
Description
FilterSettingswithexposure,temperature,tint,vibrance, andsharpnessand addedDEFAULT_FILTERSandFILTER_SLIDER_CONFIGto centralize defaults and slider metadata.applyHueShiftandclamp, appliedexposure,vibrance,temperature/tint, hue shift, and a sharpen pass that performs a lightweight high-pass sharpen whensharpness > 0.getCanvasPointhelper,handleCanvasMouseDownhit-test to start dragging on mousedown,handleCanvasMouseMoveupdates using canvas coordinates, andremoveStickernow clears selected/dragged state.Date.now()sticker IDs with a stable incrementalstickerIdRefto satisfy purity lint rules and prevented default page scrolling while moving stickers with arrow keys.FILTER_SLIDER_CONFIGso new filters appear in the sliders automatically and presets/reset now applyDEFAULT_FILTERSto avoid state carry-over.Testing
npm run lintand it passed (lint issues fixed).npm run buildand production build completed successfully.Codex Task