Skip to content

chore: update eslint incl. plugins + review rules #4236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khassel merged 3 commits into from
Aug 25, 2026
+80 −73
Merged

chore: update eslint incl. plugins + review rules #4236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3ff2f8
chore: update eslint incl. plugins
KristjanESPERANTO Aug 23, 2026
128a8b1
chore(eslint): switch to named import for jsdoc plugin
KristjanESPERANTO Aug 23, 2026
a2a044e
chore(eslint): remove dead rule overrides from js block
KristjanESPERANTO Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 3 additions & 26 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import css from "@eslint/css";
import globals from "globals";
import {flatConfigs as importX} from "eslint-plugin-import-x";
import js from "@eslint/js";
import jsdocPlugin from "eslint-plugin-jsdoc";
import {configs as jsdocConfigs} from "eslint-plugin-jsdoc";
import markdown from "@eslint/markdown";
import {configs as packageJsonConfigs} from "eslint-plugin-package-json";
import playwright from "eslint-plugin-playwright";
Expand Down Expand Up @@ -44,7 +44,7 @@ export default defineConfig([
moment: "readonly"
}
},
extends: [importX.recommended, js.configs.recommended, jsdocPlugin.configs["flat/recommended"], stylistic.configs.all],
extends: [importX.recommended, js.configs.recommended, jsdocConfigs["flat/recommended"], stylistic.configs.all],
rules: {
"@stylistic/array-element-newline": ["error", "consistent"],
"@stylistic/arrow-parens": ["error", "always"],
Expand All @@ -71,31 +71,20 @@ export default defineConfig([
"@stylistic/spaced-comment": "off",
"dot-notation": "error",
eqeqeq: ["error", "always", {null: "ignore"}],
"id-length": "off",
"import-x/extensions": "error",
"import-x/newline-after-import": "error",
"import-x/order": "error",
"init-declarations": "off",
"max-lines-per-function": ["warn", 400],
"max-statements": "off",
"no-global-assign": "off",
"no-inline-comments": "off",
"no-magic-numbers": "off",
"no-param-reassign": "error",
"no-plusplus": "off",
"no-prototype-builtins": "off",
"no-ternary": "off",
"no-throw-literal": "error",
"no-undefined": "off",
"no-unneeded-ternary": "error",
"no-useless-return": "error",
"no-warning-comments": "off",
"object-shorthand": ["error", "methods"],
"one-var": "off",
"prefer-const": "error",
"prefer-template": "error",
"require-await": "error",
"sort-keys": "off"
"require-await": "error"
}
},
{
Expand Down Expand Up @@ -137,13 +126,8 @@ export default defineConfig([
rules: {
"@stylistic/array-element-newline": "off",
"@stylistic/indent": ["error", "tab"],
"@stylistic/object-property-newline": ["error", {allowAllPropertiesOnSameLine: true}],
"@stylistic/padded-blocks": ["error", "never"],
"@stylistic/quote-props": ["error", "as-needed"],
"import-x/no-unresolved": ["error", {ignore: ["eslint/config"]}],
"max-lines-per-function": ["error", 100],
"no-magic-numbers": "off",
"one-var": ["error", "never"],
"sort-keys": "off"
}
},
Expand Down Expand Up @@ -182,16 +166,9 @@ export default defineConfig([
rules: {
"import-x/namespace": "off",
"import-x/named": "off",
"import-x/default": "off",
"import-x/extensions": "off"
}
},
{
files: ["tests/configs/modules/weather/*.js"],
rules: {
"@stylistic/quotes": "off"
}
},
{
files: ["tests/e2e/**/*.js"],
extends: [playwright.configs["flat/recommended"]],
Expand Down
116 changes: 73 additions & 43 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"@fortawesome/fontawesome-free": "^7.3.1",
"animate.css": "^4.1.1",
"croner": "^10.0.1",
"eslint": "^10.8.0",
"eslint": "^10.9.1",
"express": "^5.2.1",
"feedme": "^2.0.2",
"globals": "^17.8.0",
Expand All @@ -111,12 +111,12 @@
"@eslint/markdown": "^8.0.3",
"@stylistic/eslint-plugin": "^5.10.0",
"@vitest/coverage-v8": "^4.1.10",
"@vitest/eslint-plugin": "^1.6.24",
"@vitest/eslint-plugin": "^1.6.27",
"@vitest/ui": "^4.1.10",
"cspell": "^10.0.1",
"eslint-plugin-import-x": "^4.17.1",
"eslint-plugin-jsdoc": "^63.3.2",
"eslint-plugin-package-json": "^1.6.2",
"eslint-plugin-jsdoc": "^64.2.1",
"eslint-plugin-package-json": "^1.7.1",
"eslint-plugin-playwright": "^2.11.0",
"express-basic-auth": "^1.2.1",
"husky": "^9.1.7",
Expand Down