Conversation
|
Thanks for the PR! Can you attach a before and after screenshot? |
|
I am not sure if changing the order is a good idea. Our users are used to how this is ordered now, changing it might confuse some... But I am willing to see the change in screenshots, before making up my mind finally... |
|
@MannXo Did you noticed the request for screenshots? 🙂 |
|
@KristjanESPERANTO thank you for the reminder. |
|
@MannXo Thanks for the screenshots 🙂 Please mark which is which. I think the first is the "after" one, right? |
|
@KristjanESPERANTO indeed. |
|
@rejas What do you think? |
|
Sorry for my late answer... Thanks fro your PR. I could see something like this merged, IF we could make the order configurable. So that people could arrange them to their likings. Maybe using a flex order css property would be the solution (so people could change that order via custom css) |
|
@MannXo Did you noticed the last comment? 🙂 |
|
@KristjanESPERANTO I feel I can do that. shall I create an issue for it first? or shall I just revert my commits on this branch and implement the flex? |
|
I think it would be best to do it in this PR here. When we merge, we'll squash all the commits into one, so you don't have to worry too much about keeping the Git history clean 🙂 |
|
@rejas @KristjanESPERANTO The forecast table now has a example: |
|
Thanks for the updated approach 👏 Two concerns though:
What do you think? |
|
@MannXo Did you noticed my comment? 🙂 |
1e4c168 to
4c0a3a5
Compare
|
Okay, I decided to take this on myself since there hasn’t been any response from @MannXo so far. Migrating the forecast layout to CSS Grid was a bit tricky, but I think the result is now clean and stable. For consistency, I adapted the hourly view as well. I added screenshots into the PR text. While checking the current view, I noticed that an incorrect |


The daily forecast previously displayed its columns in a fixed order that did not match the order requested in the issue.
This PR makes the forecast column order configurable through CSS custom properties. The default order is now:
condition, min temp (low), max temp (high), UV Index, precipitation amount, precipitation probability
The hourly forecast is updated to use the same approach, with its own configurable column order.
min-tempbeforemax-temp(low before high, per [Change Request] Weather forecast: Low before High Temperature #4116)<tr>in the current weather view with a<div>Fixes #4117
forecast before
forecast after
hourly before
hourly after
Note: The PR was updated based on reviews, and the PR text was updated accordingly.