docs(compliments): fix remoteFile path after defaultmodules restructure#392
Open
Stordiau-P wants to merge 1 commit into
Open
docs(compliments): fix remoteFile path after defaultmodules restructure#392Stordiau-P wants to merge 1 commit into
Stordiau-P wants to merge 1 commit into
Conversation
- Update module directory reference from modules/default/compliments/ to defaultmodules/compliments/ - Fix example: MagicMirror root is not served statically by the webserver, use config/ instead - Verified with curl: root returns 404, config/ returns 200
Collaborator
|
this should probably based against the master branch since this is a "live! issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
remoteFiledocumentation for the compliments module is out of datefollowing the April 2026 restructure that moved default modules from
modules/default/todefaultmodules/(announced here:https://forum.magicmirror.builders/topic/20138/upcoming-release-april-1-2026-breaking-changes-some-operational-changes).
The current docs state:
modules/default/compliments/"../../compliments.json"Both of these are now incorrect.
Changes
modules/default/compliments/to
defaultmodules/compliments/.directory is not served statically by the webserver (confirmed via curl,
see below), so the example now points to
config/instead, which isconfirmed to work.
Testing
Verified manually against a clean v2.37.0 install:
../../compliments.json404 Not Found../../../compliments.json404 Not Foundconfig/directory../../config/compliments.json200 OKdefaultmodules/compliments/compliments.json304 Not Modified(i.e. working, cached)Related
Fixes the compliments module section referenced in
docs.magicmirror.builders/modules/compliments.html