Vendors: update MafiaNet to v0.10.0#212
Merged
Merged
Conversation
Bump vendored MafiaNet from v0.9.0 to v0.10.0 (commit 0ab32ce5). Notable upstream changes: scoped MafiaNet::Priority / MafiaNet::Reliability enum classes replacing the global PacketPriority / PacketReliability C enums (wire-compatible, values preserved), removal of the non-thread-safe RakNetGUID::ToString() member in favor of MafiaNet::to_string(), plus the new umbrella header, RAII handles and PointGridSectorizer. Refresh VERSION.txt, the CMakeLists pin comment and README to v0.10.0.
MafiaNet v0.10.0 replaces the global PacketPriority / PacketReliability enums with scoped MafiaNet::Priority / MafiaNet::Reliability enum classes and removes the non-thread-safe RakNetGUID::ToString() member. Update RPC/peer call sites to the new types and enumerators, and switch GUID logging to MafiaNet::to_string().
|
Caution Review failedPull request was closed or merged during review WalkthroughThis PR vendors MafiaNet 0.10.0, introduces new helper headers and utility classes, replaces legacy packet priority and reliability types with scoped ChangesMafiaNet 0.10 update
Estimated code review effort🎯 4 (Complex) | ⏱️ ~70 minutes Possibly related issues
Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the vendored MafiaNet dependency from v0.9.0 → v0.10.0 (commit
0ab32ce5) and adapts the Framework to its breaking API changes.Vendored bump (
vendors/mafianet/)Source/tree with the v0.10.0 tag (new sourcesPeerHandle.cpp,PointGridSectorizer.cpp,guid_util.cppare picked up automatically via the existingfile(GLOB ...)).VERSION.txt, theCMakeLists.txtpin comment, andREADME.mdto v0.10.0.Our-side fixes (
code/framework/)v0.10.0 turns the global C enums into scoped enum classes and removes the non-thread-safe GUID stringifier. Adapted all 6 call sites:
PacketPriority/PacketReliabilityMafiaNet::Priority/MafiaNet::ReliabilityHIGH_PRIORITY/RELIABLE_ORDEREDMafiaNet::Priority::High/MafiaNet::Reliability::ReliableOrderedIMMEDIATE_PRIORITY,LOW_PRIORITYMafiaNet::Priority::Immediate,::Lowpacket->guid.ToString()MafiaNet::to_string(packet->guid)(+#include <mafianet/guid_util.h>)Enum values are preserved upstream, so the change is wire-compatible.
Files touched:
network_peer.h,network_server.{h,cpp},network_client.cpp,integrations/client/instance.cpp.Testing
MafiaNet,Framework,FrameworkServer,FrameworkTestsbuild cleanly.RunFrameworkTests: 123/123 pass.Caveat
This was a server-only build config —
FrameworkClient(incl.network_client.cpp,integrations/client/instance.cpp) was not compiled locally. Those client edits are mechanical and verified against the new signatures, but should be confirmed in a client build.Summary by CodeRabbit
Release Notes
New Features
API Changes