Skip to content

Feat/object pool - #37

Merged
Machillka merged 3 commits into
mainfrom
feat/object-pool
Aug 23, 2026
Merged

Feat/object pool#37
Machillka merged 3 commits into
mainfrom
feat/object-pool

Conversation

@Machillka

Copy link
Copy Markdown
Owner

No description provided.

- reject invalid animation indices and malformed accessor ranges
- read interleaved float data using the declared byte stride
- return null on parse failure or unsupported animation data
- add AnimationLoader regression tests
- compute global transforms with three-state DFS
- validate parent indices and detect hierarchy cycles
- avoid publishing partial matrices for invalid skeletons
- add regression tests for parent ordering, multiple roots and malformed hierarchies
Add on-demand construction, safe growth, validated release, lifecycle cleanup, and focused regression coverage for the Core ObjectPool.
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Machillka, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c1e0eff-552b-4a6a-90a4-235dbd9143de

📥 Commits

Reviewing files that changed from the base of the PR and between 7427f11 and 72bce06.

📒 Files selected for processing (12)
  • docs/develop.md
  • engine/Runtime/Asset/src/AnimationLoader.cpp
  • engine/Runtime/Core/include/ChikaEngine/base/ObjectPool.h
  • engine/Runtime/Framework/include/ChikaEngine/subsystem/AnimationSubsystem.hpp
  • engine/Runtime/Framework/src/subsystem/AnimationHierarchy.cpp
  • engine/Runtime/Framework/src/subsystem/AnimationHierarchy.hpp
  • engine/Runtime/Framework/src/subsystem/AnimationSubsystem.cpp
  • imgui.ini
  • tests/CMakeLists.txt
  • tests/unit/AnimationHierarchyTests.cpp
  • tests/unit/AnimationLoaderTests.cpp
  • tests/unit/ObjectPoolTests.cpp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Machillka
Machillka merged commit 4c67dbc into main Aug 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant