DF Robot - Primary Code Merge to Driver Base - #65
Open
sullynumber9 wants to merge 1 commit into
Open
Conversation
chosterto
reviewed
Jun 24, 2026
| uint16_t ec; | ||
|
|
||
| uint8_t data_length; | ||
| uint16_t crc16_result; |
Member
There was a problem hiding this comment.
crc16_result is not needed in here
|
|
||
| // No nulls, proceed with reading from the sensor | ||
|
|
||
| uint8_t command[8] = {0x01, 0x03, 0x00, 0x00, 0x00, 0x04, 0x44, 0x09}; |
Member
There was a problem hiding this comment.
Add a comment describing the command structure, this seems pretty vague
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge yet, using this to separte commands for PR evaluation & to make the PRs easier to work with