Make ChoiceDeltaToolCall.index optional - #380
Merged
Merged
Conversation
JaredConover
approved these changes
Sep 25, 2025
JaredConover
left a comment
JaredConover
left a comment
Contributor
There was a problem hiding this comment.
I noticed this is an issue for other endpoints/properties as well.
The openAI spec doesn't mark very many of these params as required, so I don't think parsing should automatically fail if they're not present.
JaredConover
left a comment
JaredConover
left a comment
Contributor
There was a problem hiding this comment.
Does this need to be run through the generator?
nezhyborets
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make ChoiceDeltaToolCall.index optional
Why
According to the OpenAI documentation, this property is not required in the response. ChatGPT always returns the index property, but some other providers omit it.