Repository navigation
Fix sensor fault handling, harden OTA release signing, and bump firmware to 0.6.3 - #77
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
mic.censure the microphone measurement is only marked valid after FFT bands are actually computed by skippingm->mic_okand returning early whenfft_count < 64, and log the short-capture case.accel.cmakesample_xyz()fail the sample on a data-ready timeout (returnfalse) instead of falling through to read stale registers soaccel_read()rejects short captures.audio.cadd explicit nonce validity tracking (nonce_usable), makerotate_nonce()fail closed on RNG errors (advertise an inert nonce and log), and haveauthenticate()rejectSTARTwhile the nonce is unusable.ota.cafterlink_claim(LINK_OWNER_OTA)request the same faster BLE parameters used by audio (short interval units, max data length and 2M PHY) while preserving synchronous write-with-response flash flow control.src/hive_config.hfrom0.6.2to0.6.3and correct the advertising-interval comment to say the device is connectable.sysbuild/mcuboot.confcomment and make.github/workflows/release.ymlrequire aHIVEINSIDE_SIGNING_KEY_PEMsecret, write it securely to the runner, pass it into the sysbuild with-DSB_CONFIG_BOOT_SIGNATURE_KEY_FILE=..., and verify MCUboot selected it before accepting artifacts.docs/ota-over-ble.mdanddocs/flashing.md, and keep theota_init()filter-accept-list TODO referenced as the remaining coordinated work with HiveHub.Testing
ruby -e 'require "yaml"; YAML.parse_file(".github/workflows/release.yml")') and it succeeded.find/testchecks forprj.conf,app.overlay, absence ofplatformio.ini/zephyr/parts) and they passed.0.6.3and that the release workflow includes the signing-key guard; these assertions passed.git diff --checkand other repository checks (rg/sed/nlinspections used during the rollout) with no failures; note that fullwest --sysbuildbuilds for both variants were not executed in this environment becausewestis not installed.Codex Task